Support for Rails 5

[elektronaut]

Hi! I'd really love to have this gem updated for Rails 5.

I've taken the work done by @schuylr in #32, rebased onto master and fixed the tests so that they're running on the final 5.0 release without deprecations.

This bumps the version to 2.0.0 and drops support for Rails 4.

[cguyer]

Can we get this merged in. Also @elektronaut happen to have a fork of this public till merge?

[elektronaut]

@cguyer sure, I've been using this:

gem "actionpack-page_caching",
    git: "https://github.com/kord-as/actionpack-page_caching",
    branch: "rails5"

[RogerE]

There does not seem to be much focus on this gem from Rails core. Understandable of course, they probably don't use it and have lots if other things to deal with. Maybe it could be spun out from the Rails umbrella like acts_as_list and will_paginate?

[elektronaut]

The only real change here is renaming an after_filter callback to after_action, the rest is just test instrumentation and version housekeeping. Please let me know if there's anything else I can do to facilitate a release.

FWIW, I've still got several projects depending on this, and I'm willing to throw my hat in the ring and maintain it as-is if the Rails core team wants to abandon it.

[rafaelfranca]

No need of this.

[rafaelfranca]

We should keep this if we are not dropping support to it

[rafaelfranca]

Why those ruby versions are being removed?

[schuylr]

@rafaelfranca I noticed your diff comments which are mostly on my legwork - unfortunately we can't support both Rails 4.x and Rails 5 in the same codebase. Subsequently, Rails 5 doesn't support the older Ruby versions that you're inquiring as to why they're being removed.

See these comments:

#31 (comment)
#32 (comment)

Lastly, the >= 5.0.0beta1.0 was when Rails was an official beta and not installable without this line. I agree that it is now unnecessary with the release of 5.0.

I would follow @eileencodes's suggested strategy, and derive two supported branches with a bump to v2 for this gem.

[rafaelfranca]

I think we can support Rails 4 and older versions of ruby. There is no changes in the code base only in the test suite. In that case is possible to only run Rails 5 with the supported versions and it is possible to conditionally define code depending in the Rails version to make the test suite pass with 4.x.

[elektronaut]

I agree, Rails 4.x support is totally possible.

I've got 4.0, 4.1, 4.2 and 5.0 working locally, let's see what the CI says.

[elektronaut]

That should do the trick. I've changed the version number to a point release, since that would be more appropriate.

[romenigld]

Thank's elektronaut!! works fine for me:

gem "actionpack-page_caching",
    git: "https://github.com/kord-as/actionpack-page_caching",
    branch: "rails5"

[pixeltrix]

@elektronaut sorry, I couldn't use this PR but hopefully you'll be happy now that Rails 5.0 support has been officially added - thanks for your contribution.

[RogerE]

Will there be a new gem version released for this?

[pixeltrix]

@RogerE Yes - I'm also tidying up the action caching gem and will be releasing a new version of that too.

[RogerE]

@pixeltrix excellent, thanks!

[tomhughes]

Is there any news on getting the new version out?

[sighmon]

@tomhughes I've pointed my Gemfile directly at this git repo to test it out with Rails 5.

gem 'actionpack-page_caching', git: 'https://github.com/rails/actionpack-page_caching.git'

[pixeltrix]

@tomhughes I'll be getting releases out for this and action gems out over Christmas

[enrico]

@pixeltrix Any chance we will also get a new gem version for rails/rails-observers ?
actionpack-page_caching and rails-observers are the only 2 entries in my Gemfile not requiring a specific version and instead pointing to git directly...

[pixeltrix]

@enrico not sure about rails-observers - will have to check what's involved in that

[jaredmdobson]

Any help needed with this?

[pixeltrix]

@onesupercoder actionpack-page_caching or rails-observers? No for the former and yes for the latter 😄

I'm just writing a blog post for the release of this and the action caching gem - out at the weekend.

[jaredmdobson]

Awesome!! Thanks a million! :-)

…

On Jan 19, 2017 2:32 AM, "Andrew White" ***@***.***> wrote: @onesupercoder <https://github.com/onesupercoder> actionpack-page_caching or rails-observers? No for the former and yes for the latter 😄 I'm just writing a blog post for the release of this and the action caching gem - out at the weekend. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#41 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAFA0wN34osXw5yR-eTBsmC5AiIxBGZuks5rTy2sgaJpZM4KBunx> .