Skip to content

Tests use deprecated ActionDispatch::ParamsParser::ParseError #20

@sorenstoutner

Description

@sorenstoutner

The tests currently use the deprecated ActionDispatch::ParamsParser::ParseError.

https://github.com/rails/actionpack-xml_parser/blob/master/test/xml_params_parsing_test.rb#L71

This causes them to fail with the following error.

  1) Error:
XmlParamsParsingTest#test_occurring_a_parse_error_if_parsing_unsuccessful:
NameError: uninitialized constant ActionDispatch::ParamsParser
    test/xml_params_parsing_test.rb:71:in `block (2 levels) in <class:XmlParamsParsingTest>'
    test/xml_params_parsing_test.rb:122:in `block in with_test_routing'
    test/helper.rb:74:in `with_routing'
    test/xml_params_parsing_test.rb:118:in `with_test_routing'
    test/xml_params_parsing_test.rb:67:in `block in <class:XmlParamsParsingTest>'

For the Debian packaging, I am currently working around this by simply skipping the test.

https://salsa.debian.org/ruby-team/ruby-actionpack-xml-parser/-/blob/master/debian/patches/skip-test-that-depends-on-deprecated-exception.patch?ref_type=heads

But it would probably be better to actually fix the test.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions