Add activerecord integration test coverage
#432
Merged
+110
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpdoyle
force-pushed
the
coder-activerecord
branch
from
6326428 to
bf66c67
Compare
Follow-up to [rails#420][] Background --- The introduction of `ActiveResource::Base.coder` and the `ActiveResource::Coder` class added support for encoding and decoding instances of `Base`. The intent was to integrate with the Active Record [.serialize][] method. Problem --- While the `Coder` class and `Serialization` module aim to comply with Active Record, there's still potential for that compatibility to drift of break without sufficient test coverage. Proposal --- This commit adds a test-only dependency on `activerecord` and `sqlite3` so that the serialization test coverage can include database-level reads and writes. The suite is configured to use the in-memory SQLite adapter so that there are no need for migrations or external database configuration. [rails#420]: rails#420 [.serialize]: https://api.rubyonrails.org/classes/ActiveRecord/AttributeMethods/Serialization/ClassMethods.html#method-i-serialize
seanpdoyle
force-pushed
the
coder-activerecord
branch
from
bf66c67 to
c80ab7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #420
Background
The introduction of
ActiveResource::Base.coderand theActiveResource::Coderclass added support for encoding and decoding instances ofBase. The intent was to integrate with the Active Record .serialize method.Problem
While the
Coderclass andSerializationmodule aim to comply with Active Record, there's still potential for that compatibility to drift of break without sufficient test coverage.Proposal
This commit adds a test-only dependency on
activerecordandsqlite3so that the serialization test coverage can include database-level reads and writes. The suite is configured to use the in-memory SQLite adapter so that there are no need for migrations or external database configuration.