Remove importmap:pins rake task in favor of bin/importmap json CLI
#43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This rake task was added in f42f53e before the `bin/importmap` CLI existed. Its function is identical to the `bin/importmap json` command, though, so let's remove it to consolidate around the `bin/importmap` CLI (which also hosts the `pin` and `unpin` commands).
|
@dhh Curious to get your thoughts on this proposal - Is there a benefit to keeping the rake task now that we have the CLI which does the same (and offers additional commands)? My preference would be to keep it simple and just offer the CLI, but if you see value in the duplicate task I can close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
importmap:pinsrake task was added in f42f53e before thebin/importmapCLI existed. Its function is identical to thebin/importmap jsoncommand, though, so I'm proposing we remove the rake task in an effort to consolidate around just thebin/importmapCLI (which also hosts thepinandunpincommands).