partial! + :locals #251
Merged
partial! + :locals #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`partial! partial: 'name', locals: { foo: 'bar' }` is in fact not supported ATM
|
Sweet. Thanks for PR. Will release a new version shortly. |
|
🆒 |
|
Released 2.2.9 |
|
Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was surprised to see that
partial!doesn't handle:localsoption in the same way as ActionView.There was a comment in code that implies
partial! partial: 'name', locals: { foo: 'bar' }would work, but in fact that code does not work, and does not even tested.So here's an implementation with tests for:
json.partial! 'partial_name', locals: {foo: 'bar}and
json.partial! 'partial_name', foo: 'bar