Adds jQuery 3 support #224
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
The build failure is because of mime-types-data dropping support for 1.9.3, apparently. |
|
It would be cool if there was an option to include jquery3-slim as well. Any chance this is going to get merged? |
|
@cannikin you should probably either remove Ruby 1.9.3 tests and drop support for it in the gemspec or limit the mime-types version (personally I think the first one is a better choice) |
|
@connorshea I'm waiting on a core member to say which of those two options is preferred... |
|
@cannikin given that the last version of Rails to support 1.9.3 was 4.0, and it recommended at least 2.0, it should be fine to drop support for it. |
|
Could you remove the files inside |
|
Done! |
|
Oh, not all of them just the files that were added. Sorry for not being clear. |
|
Whoops! Done again! |
|
Thank you. I'll release it later. |
This should contain all the changes necessary to support jQuery 3 except for the actual JS files themselves. I know that for security reasons you can't accept pull requests with new jQuery code. This PR contains the shell of the JS files themselves (to be sure everything is named correctly) but they're empty, ready to be populated with the actual code.