Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix jQuery version constant #97

Merged
merged 1 commit into from
Jan 21, 2013
Merged

Fix jQuery version constant #97

merged 1 commit into from
Jan 21, 2013

Conversation

ai
Copy link
Contributor

@ai ai commented Jan 21, 2013

Fix JQUERY_VERSION.

@ai ai mentioned this pull request Jan 21, 2013
Closed
JangoSteve added a commit that referenced this pull request Jan 21, 2013
@JangoSteve
Merge pull request #97 from ai/fix_version
01e32a6 
Fix jQuery version constant
@JangoSteve JangoSteve merged commit 01e32a6 into rails:master Jan 21, 2013
@ai
Copy link
Contributor Author

ai commented Jan 22, 2013

What about #98 . It’s not a first issue in version constant.

@JangoSteve
Copy link
Member

I think we like explicitly having the version numbers written in that file. Makes it easy and convenient to see what's included.

@ai
Copy link
Contributor Author

ai commented Jan 22, 2013

Hm. Maybe we should add Travis task, to detect wrong version on pull request or push?

@kenn kenn mentioned this pull request Feb 3, 2013
Closed
@kenn
Copy link
Contributor

kenn commented Feb 3, 2013

Could you point release this fix? jquery-rails-cdn depends on this constant and needs this fix. kenn/jquery-rails-cdn#15

@JangoSteve
Copy link
Member

Just pushed 2.2.1. Also includes latest jquery-ujs and jquery 1.9.1.

@JangoSteve
Copy link
Member

@ai We use rake release to tag, push to Github, and release on Rubygems.org. Maybe we could override the release task to have it cross-check the version numbers, abort if they're mismatched, and delegate to the existing release task if everything is okay. If someone wanted to submit that, I'd pull it in.

kenn added a commit to kenn/jquery-rails that referenced this pull request Feb 8, 2013
@kenn
Check version before rake release. Refs rails#97
7c0ee2b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ai @JangoSteve @kenn