Fix jQuery version constant #97

Merged
merged 1 commit into from Jan 21, 2013

Projects

None yet

3 participants

@ai
Contributor
ai commented Jan 21, 2013

Fix JQUERY_VERSION.

@JangoSteve JangoSteve merged commit 01e32a6 into rails:master Jan 21, 2013
@ai
Contributor
ai commented Jan 22, 2013

What about #98 . It’s not a first issue in version constant.

@JangoSteve
Member

I think we like explicitly having the version numbers written in that file. Makes it easy and convenient to see what's included.

@ai
Contributor
ai commented Jan 22, 2013

Hm. Maybe we should add Travis task, to detect wrong version on pull request or push?

@kenn kenn referenced this pull request in kenn/jquery-rails-cdn Feb 3, 2013
Closed

Jquery.js is correct, but google cdn version is still 1.8.3 #15

@kenn
Contributor
kenn commented Feb 3, 2013

Could you point release this fix? jquery-rails-cdn depends on this constant and needs this fix. kenn/jquery-rails-cdn#15

@JangoSteve
Member

Just pushed 2.2.1. Also includes latest jquery-ujs and jquery 1.9.1.

@JangoSteve
Member

@ai We use rake release to tag, push to Github, and release on Rubygems.org. Maybe we could override the release task to have it cross-check the version numbers, abort if they're mismatched, and delegate to the existing release task if everything is okay. If someone wanted to submit that, I'd pull it in.

@kenn kenn added a commit to kenn/jquery-rails that referenced this pull request Feb 8, 2013
@kenn kenn Check version before rake release. Refs #97 7c0ee2b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment