Skip to content

after_change callback not working for unique_list #64

@vsmay98

Description

@vsmay98

Hi,
While using after_change callback for unique_list the after change method is not getting invoked.

Code:

class Person < ApplicationRecord
  kredis_list :names, after_change: ->(p) {  }
  kredis_unique_list :skills, limit: 2, after_change: :skillset_changed

  def skillset_changed
    puts 'skillset_changed'
  end
end
Loading development environment (Rails 7.0.0)
3.0.0 :001 > Person.last.skills << 'rails'
  Person Load (0.2ms)  SELECT "persons".* FROM "persons" ORDER BY "persons"."id" DESC LIMIT ?  [["LIMIT", 1]]
  Kredis Proxy (0.0ms)  LREM persons:2:skills [0, "rails"]
  Kredis Proxy (0.0ms)  RPUSH persons:2:skills ["rails"]
  Kredis Proxy (0.0ms)  LTRIM persons:2:skills [-5, -1]
 => [0, 2, "OK"]

Fix:
Kredis::Types::UniqueList was missing from the AFTER_CHANGE_OPERATIONS constant

I will raise a PR to fix the above issue

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions