Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid double callbacks in Rails >= 4.1 #81

Merged
merged 1 commit into from
May 9, 2016
Merged

Avoid double callbacks in Rails >= 4.1 #81

merged 1 commit into from
May 9, 2016

Conversation

pacoguzman
Copy link
Contributor

This PR provides the same solution like #78 but I've added a test.

I wasn't able to use any person model combination to reproduce the problem that's why I've added the NestedBattle model

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@arthurnn arthurnn merged commit 7eec0fa into rails:master May 9, 2016
@arthurnn
Copy link
Member

arthurnn commented May 9, 2016

Thanks

@westonganger
Copy link

Do you think you could release version 1.1.4 with this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants