I've applied a patch that fixes a conflict with devise:install

[walterdavis]

This patch: fcbf454 fixes a problem I had with Devise install. Without it, I would get a NoMethodError which traces back to prototype-rails.on_load_action_view.rb:17 after trying to run rails g devise:install

[jeremy]

Could you check whether TestCase is loaded, rather than checking Rails.env?

[walterdavis]

Sure, happy to. How would you do that?

if ( ActionView::TestCase )

or is there a general "is this loaded" method I should use?

Walter

On Feb 12, 2013, at 1:57 PM, Jeremy Kemper wrote:

Could you check whether TestCase is loaded, rather than checking Rails.env?

—
Reply to this email directly or view it on GitHub.

[walterdavis]

I couldn't figure out how to get a new pull request without closing this one, so that's what I did. Please let me know if that technique I used is acceptable.

Walter

On Feb 12, 2013, at 1:57 PM, Jeremy Kemper wrote:

Could you check whether TestCase is loaded, rather than checking Rails.env?

—
Reply to this email directly or view it on GitHub.

[carlosantoniodasilva]

@walterdavis there's no problem, but you can actually use the same pull request by pushing new commits or push forcing to the same branch in your fork. Github takes care of updating the pull request properly. We usually ask people to squash their commits into 1 and push force to the same branch, because it's harder to follow discussions in different pull requests. Thanks for your contribution.