Fix ruby 2.7 warnings #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Aubin Lorieux <aubin.lorieux@gmail.com>
Co-authored-by: Aubin Lorieux <aubin.lorieux@gmail.com>
This was referenced May 5, 2020
mingan
added a commit
to mingan/rails-controller-testing
that referenced
this pull request
Jun 28, 2020
Empty kwargs occur in simple calls without any parameters or headers, e.g. `get '/some/path`. Code added in rails#58 passes empty kwargs in the form of an empty hash to ActionPack that considers it not to be compatible with the new kwargs-style syntax and emits useless a deprecation warning.
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #51, rebased on #56