-
Notifications
You must be signed in to change notification settings - Fork 574
Add rbenv module #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rbenv module #13
Conversation
The experience I want for the users of the dev box is: you run vagrant up and presto you are ready. In particular the box provides by default the distro package because albeit it is an early version, it is 1.9.3, passes the test suite, and it is already compiled. So a download of the binaries is enough. I don't want to preinstall any version manager "just in case", because people can install their preferred one easily. In the case of RVM that is basically a one-liner ahead so no need to bother. One thing I would be willing to merge, though, is installing RVM with a compiled binary. When I built the dev box no binary seemed to be available for it, rvm downloaded the tarball for compilation, so it was discarded. What I want to avoid is compilation, but it we can substitute the Ubuntu package with precompiled Ruby for RVM that is more recent then that would be an improvement. |
@fxn I understand your opinion. but I think 1.9.3p0 have some exploit, such as http://www.ruby-lang.org/en/news/2012/11/09/ruby19-hashdos-cve-2012-5371/ . 1.9.3p0 doesn't use in production. We need to run test suite with real case. So, I don't have solution that quick |
@hsbt does rbenv provide precompiled binaries now? If it does rbenv is fine as well, my only concern is not to compile source code by default. |
No, rbenv cann't provide binaries in official function. I'll build to 1.9.3-p327 in dev box and adding this binary to repository. later I modified puppet manifests to use precompiled binary default. this solution have two problem:
|
Yep, not really convinced by that approach. Think that in practice for the majority of PRs the patchlevel does not really matter for the developer, he hacks his patch, the suite passes, and issues a PR. Provisioning a better patchlevel is not worth the price of those compromises in my view. Also take into account that the project has Travis as a safety net. A more modern Ruby would be preferable, but it should be provisioned in a similar quick and standard way. |
I agreed. I'm going to develop to rbenv manifests in my fork. If I found any solutions, I pull request it. rails-dev-box is good solution. I loved it. Thanks. |
Awesome :), I am in parallel exploring what is the state of binary install with rvm today. |
Went with RVM finally d5cae27, binary install, and recent patchlevel. |
it looks awesome! thank you nudge me. |
We need to run test with any version of ruby. but Rails development box provided only system ruby. system ruby in precise32 is 1.9.3p0. this version is little old.
I added puppet manifest for rbenv and ruby-build. now vagrant user can use
rbenv install 1.9.3-p327
Thanks.