Skip to content

Raise an error when provided an invalid Range, or invalid :minimum and :maximum #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2024
Merged

Raise an error when provided an invalid Range, or invalid :minimum and :maximum #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/rails/dom/testing/assertions/selector_assertions/html_selector.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,11 @@ def extract_equality_tests(refute)
else
comparisons[:minimum] ||= 1
end

if comparisons[:minimum] && comparisons[:maximum] && comparisons[:minimum] > comparisons[:maximum]
raise ArgumentError, "Range begin or :minimum cannot be greater than Range end or :maximum"
end

comparisons
end
end
Expand Down
14 changes: 14 additions & 0 deletions test/selector_assertions_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,20 @@ def test_assert_select_text_match
end
end

def test_assert_select_with_invalid_range
render_html "<div>foo</div>"
error = assert_raises(ArgumentError) { assert_select("div", 2..1) { nil } }
assert_equal "Range begin or :minimum cannot be greater than Range end or :maximum", error.message
end

def test_assert_select_with_invalid_minimum_and_maximum
render_html "<div>foo</div>"
error = assert_raises(ArgumentError) { assert_select("div", maximum: 0) { nil } }
assert_equal "Range begin or :minimum cannot be greater than Range end or :maximum", error.message
error = assert_raises(ArgumentError) { assert_select("div", minimum: 2, maximum: 1) { nil } }
assert_equal "Range begin or :minimum cannot be greater than Range end or :maximum", error.message
end

#
# Test assert_not_select.
#
Expand Down