Fix #26 by running assertion when we aren't testing for a body.

[kaspth]

Fixes #26.

I was wondering if we should run an always passing assertion though.

Imagine a user writing assert_select 'body', 0 and then running the tests to find the assertion count doesn't go up.

What do you think, @rafaelfranca and @chancancode?

[kaspth]

Only the rubinius version failed. Travis says the gems might be corrupted. Do you know of a fix, Rafael?

[rafaelfranca]

I didn't get the always passing assertion. Could you explain better?

[kaspth]

I couldn't find an assertion to run in this case except one that will always pass like assert true.

Kasper

Den 18/11/2014 kl. 15.51 skrev Rafael Mendonça França notifications@github.com:

I didn't get the always passing assertion. Could you explain better?

—
Reply to this email directly or view it on GitHub.

[rafaelfranca]

I see. I think we should run them.

About rbx, let remove it from our suite from now.

We need to change code on Rails right?

[kaspth]

Okay, I'll add an assert true.

Yes, we need to revert this: rails/rails#17107

[kaspth]

@rafaelfranca I've changed it a bit now. No longer is assert_size_match polluted and a more elaborate comment is added.

Note I'm calling return after running the assert true so this will break:

assert_select 'body', 0 do
  # block won't be run
end

Is that okay? I can't think of a situation where people would nest a call to a document that had no body.

[rafaelfranca]

I don't think this block case is valid. If you are using 0 as count you don't want to see the element in the response so it doesn't make sense to assert something inside it.

[rafaelfranca]

Applied rails/rails@1b9e85d