ci: add coverage for system libxml2 #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavorjones
force-pushed
the
125-nokogiri-system-libraries
branch
3 times, most recently
from
58bc051 to
25bff81
Compare
flavorjones
force-pushed
the
125-nokogiri-system-libraries
branch
from
25bff81 to
470ed3f
Compare
Specifically the patch that affects this behavior is nokogiri/patches/libxml2/0002-Update-entities-to-remove-handling-of-ssi.patch which was introduced to avoid server-side-include vulnerabilities, see sparklemotion/nokogiri@4852e43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#125 reported test failures when running with Nokogiri using system (unpatched) libxml2. This PR updates the tests to accept either form of output (the tests in question are specifically checking for escaped quotes and not escaped
<and>characters).The Nokogiri patch that affects this behavior is
which was introduced to avoid server-side-include vulnerabilities, see sparklemotion/nokogiri@4852e43