Handle data URLs better #134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goromlagche
force-pushed
the
handle-data-mediatypes-better
branch
from
3f0a725
to
97e67bc
Compare
|
Thank you for proposing these changes. I'll take a deeper look shortly. |
|
I think there's a deeper conversation about the functional drift between Loofah and rails-html-sanitizer, and I've started a discussion about it at #136 Until that discussion has been had, I'd like to hold off on making a decision about this specific solution. |
|
That's awesome. I was thinking about something along the line, but just was not sure how to implement the same. 👍 |
|
Hi, @goromlagche, thanks so much for your patience on this. I'm preparing a security release of Rails::Html::Sanitizer and I've decided to implement a slightly different solution that involves depending on a refactored Loofah class. I'll follow up with you in #135 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to address #135