-
Notifications
You must be signed in to change notification settings - Fork 21.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #16056 from sgrif/sg-required-associations
Add a `required` option to singular associations
- Loading branch information
Showing
4 changed files
with
105 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,82 @@ | ||
require "cases/helper" | ||
|
||
class RequiredAssociationsTest < ActiveRecord::TestCase | ||
self.use_transactional_fixtures = false | ||
|
||
class Parent < ActiveRecord::Base | ||
end | ||
|
||
class Child < ActiveRecord::Base | ||
end | ||
|
||
setup do | ||
@connection = ActiveRecord::Base.connection | ||
@connection.create_table :parents, force: true | ||
@connection.create_table :children, force: true do |t| | ||
t.belongs_to :parent | ||
end | ||
end | ||
|
||
teardown do | ||
@connection.execute("DROP TABLE IF EXISTS parents") | ||
@connection.execute("DROP TABLE IF EXISTS children") | ||
end | ||
|
||
test "belongs_to associations are not required by default" do | ||
model = subclass_of(Child) do | ||
belongs_to :parent, inverse_of: false, | ||
class_name: "RequiredAssociationsTest::Parent" | ||
end | ||
|
||
assert model.new.save | ||
assert model.new(parent: Parent.new).save | ||
end | ||
|
||
test "required belongs_to associations have presence validated" do | ||
model = subclass_of(Child) do | ||
belongs_to :parent, required: true, inverse_of: false, | ||
class_name: "RequiredAssociationsTest::Parent" | ||
end | ||
|
||
record = model.new | ||
assert_not record.save | ||
assert_equal ["Parent can't be blank"], record.errors.full_messages | ||
|
||
record.parent = Parent.new | ||
assert record.save | ||
end | ||
|
||
test "has_one associations are not required by default" do | ||
model = subclass_of(Parent) do | ||
has_one :child, inverse_of: false, | ||
class_name: "RequiredAssociationsTest::Child" | ||
end | ||
|
||
assert model.new.save | ||
assert model.new(child: Child.new).save | ||
end | ||
|
||
test "required has_one associations have presence validated" do | ||
model = subclass_of(Parent) do | ||
has_one :child, required: true, inverse_of: false, | ||
class_name: "RequiredAssociationsTest::Child" | ||
end | ||
|
||
record = model.new | ||
assert_not record.save | ||
assert_equal ["Child can't be blank"], record.errors.full_messages | ||
|
||
record.child = Child.new | ||
assert record.save | ||
end | ||
|
||
private | ||
|
||
def subclass_of(klass, &block) | ||
subclass = Class.new(klass, &block) | ||
def subclass.name | ||
superclass.name | ||
end | ||
subclass | ||
end | ||
end |