ActiveResource json updates #1115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wow, I was working on this right now. I absolutely like this but I don't know if is a good idea include it in 3.1 or wait until 3.2 because it can break some apps that rely in the fact that xml is default now |
|
You can still use xml by setting This change is in line with the AC scaffold generators for 3.1 which default to json, if we did not change this then AC and ARes would not be in sync. Let me know if you experience any issues and we can get them fixed.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Guys,
This corrects the ActiveResource gem and tests to work with json (with root) for 3.1.
I will add some further tests for rootless-json within the coming days.
Enjoy,
Josh