support :unless_exist for FileCache #11785
Conversation
|
@rafaelfranca can you review/merge ? |
|
@grosser : Maybe you could add a changelog entry? |
|
Added! |
|
bump plz merge |
|
|
||
| def test_write_with_unless_exist | ||
| assert_equal true, @cache.write(1, "aaaaaaaaaa") | ||
| assert_equal false, @cache.write(1, "aaaaaaaaaa", :unless_exist => true) |
There was a problem hiding this comment.
Please use 1.9 style for hashes
There was a problem hiding this comment.
Done, merge ? :)
On Fri, Aug 30, 2013 at 11:06 AM, Paul Nikitochkin <notifications@github.com
wrote:
In activesupport/test/caching_test.rb:
@@ -709,6 +709,13 @@ def test_log_exception_when_cache_read_fails
@cache.send(:read_entry, "winston", {})
assert @buffer.string.present?
end
+
- def test_write_with_unless_exist
- assert_equal true, @cache.write(1, "aaaaaaaaaa")
- assert_equal false, @cache.write(1, "aaaaaaaaaa", :unless_exist => true)
Please use 1.9 style for hashes
—
Reply to this email directly or view it on GitHubhttps://github.com//pull/11785/files#r6081952
.
There was a problem hiding this comment.
Then find someone :D
On Fri, Aug 30, 2013 at 12:35 PM, Paul Nikitochkin <notifications@github.com
wrote:
In activesupport/test/caching_test.rb:
@@ -709,6 +709,13 @@ def test_log_exception_when_cache_read_fails
@cache.send(:read_entry, "winston", {})
assert @buffer.string.present?
end
+
- def test_write_with_unless_exist
- assert_equal true, @cache.write(1, "aaaaaaaaaa")
- assert_equal false, @cache.write(1, "aaaaaaaaaa", :unless_exist => true)
I'm not rails committer :)
—
Reply to this email directly or view it on GitHubhttps://github.com//pull/11785/files#r6083281
.
|
@grosser : Could you rebase please ? |
|
Done On Fri, Aug 30, 2013 at 12:50 PM, Robin Dupret notifications@github.comwrote:
|
|
bump |
support :unless_exist for FileCache Conflicts: activesupport/CHANGELOG.md activesupport/test/caching_test.rb
@josevalim same as #6252