[ci skip] #find_in_batches doesn't support :include option #16893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This makes the example disagree with the preceding paragraph, which still says 1000. For the guide, I think it's better to leave the batch size at the default: let's just remove the parameter instead: Invoice.find_in_batches do |invoices|Also, let's retain the current active-voice spelling of the comment; that seems more likely to be how it would be written in our theoretical code base. Thanks for spotting this! 💙 |
|
@matthewd - Updated! Please have a look at it again. |
| export.add_invoices(invoices) | ||
| end | ||
| ``` | ||
|
|
||
| NOTE: The `:include` option allows you to name associations that should be loaded alongside with the models. | ||
|
|
||
| ##### Options for `find_in_batches` | ||
|
|
||
| The `find_in_batches` method accepts the same `:batch_size` and `:start` options as `find_each`, as well as most of the options allowed by the regular `find` method, except for `:order` and `:limit`, which are reserved for internal use by `find_in_batches`. |
There was a problem hiding this comment.
Sorry I missed this before: I think the second half of this sentence (from "as well as") is a lie too.
|
@matthewd - Updated! |
matthewd
added a commit
that referenced
this pull request
Sep 12, 2014
[ci skip] #find_in_batches doesn't support :include option
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.