Fixed AR::Relation#group method when argument is a SQL reserved keyword #18722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdan
force-pushed
the
group-by-key-word
branch
from
5243d97 to
e94330f
Compare
rafaelfranca
added a commit
that referenced
this pull request
Jan 29, 2015
Fixed AR::Relation#group method when argument is a SQL reserved keyword
rafaelfranca
added a commit
that referenced
this pull request
Jan 29, 2015
Fixed AR::Relation#group method when argument is a SQL reserved keyword Conflicts: activerecord/CHANGELOG.md activerecord/lib/active_record/relation/query_methods.rb
|
Maybe it was a regression at some point but I didn't analyse that. Maybe requires backport. |
rafaelfranca
added a commit
that referenced
this pull request
Jan 29, 2015
Fixed AR::Relation#group method when argument is a SQL reserved keyword Conflicts: activerecord/CHANGELOG.md activerecord/lib/active_record/relation/query_methods.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed ActiveRecord::Relation#group method when argument is SQL reserved key word:
Bonus: removed unnecessary argument for
build_select