Reset @dirty to false when slicing an instance of SafeBuffer #2344
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the warning being throw in
actionpack/capture_helper_test#test_flush_output_buffer_concats_output_buffer_to_response
After the OutputBuffer was being flushed by calling
[0,0]
on it the@dirty
instance variable was not initialized in the new instance. This was throwing a warning.The fix here will set the
@dirty
instance variable tofalse
on the new instance when the slice method is invoked.