Remove json gem dependency #23453
Merged
Remove json gem dependency #23453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All modern Rubies ship JSON as part of stdlib. Using the gem actually hurts multi-platform support due to build difficulties on Windows.
rafaelfranca
added a commit
that referenced
this pull request
Feb 3, 2016
Remove json gem dependency
This was referenced Feb 13, 2016
This was referenced Mar 23, 2016
lucaspiller
added a commit
to ifad/ruote-postgres
that referenced
this pull request
Apr 5, 2016
bdewater
added a commit
to bdewater/mollie-api-ruby
that referenced
this pull request
Jul 4, 2016
All Ruby versions >= 1.9.3 include the JSON gem in the standard library, so this requirement is redundant. See rails/rails#23453 Also: Ruby 2.4 will be bundled with a ~> 2.0 version of JSON for compatibility with the unification of Fixnum and Bignum into Integer.
|
@mperham I know this is a little late, but this change actually led to some very undesirable behavior which I describe here: rubygems/bundler#5419 Could you explain what you mean by:
Given the issue I describe in the ticket linked above--that you could end up with a different version of json in test then in production--are these build difficulties a reasonable trade-off? |
2 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All modern Rubies ship JSON as part of stdlib. Using the gem actually hurts multi-platform support due to build difficulties on Windows.