Skip to content

Identity map: use it when using find(ID) and add log message #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Identity map: use it when using find(ID) and add log message #251

wants to merge 2 commits into from

Conversation

miloops
Copy link
Contributor

@miloops miloops commented Apr 3, 2011

2 commits on this pull request:

  1. Try to use IM when loading records by id using AR::Base#find()
  2. Add log message if a record is loaded from IM.

@josevalim
Copy link
Contributor

Hey Emilio, +1 for the first commit but I am not sure if we need to log it. Won't it be too verbose in cases where I am doing a find(:all) for example?

@josevalim
Copy link
Contributor

Nah, I have applied both. If the log becomes annoying, we can always revert it later. :D

@josevalim josevalim closed this Apr 4, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miloops @josevalim