Skip to content

Conversation

arunagw
Copy link
Member

@arunagw arunagw commented Oct 22, 2011

Inspect was showing

<ActiveSupport::Cache::Strategy::LocalCache::Middleware:0x007fc5edba6480

But if we use name then it will show simply

ActiveSupport::Cache::Strategy::LocalCache

@vijaydev
Copy link
Member

I would rather change the middleware stack inspect to return the name instead of calling to_s.

@fxn @josevalim Thoughts?

@vijaydev vijaydev mentioned this pull request Oct 22, 2011
tenderlove added a commit that referenced this pull request Oct 22, 2011
Using middleware name to show proper name in the info
@tenderlove tenderlove merged commit c330905 into rails:master Oct 22, 2011
tenderlove added a commit that referenced this pull request Oct 22, 2011
This reverts commit c330905, reversing
changes made to 1c1c3fc.
@arunagw
Copy link
Member Author

arunagw commented Oct 23, 2011

Any other solution in mind to fix this? Need to change inspect for ActiveSupport::Cache::Strategy::LocalCache ??

@fxn
Copy link
Member

fxn commented Oct 23, 2011

Need to check the room log, but since Rack middleware have no convention to print themselves, and we can have arbitrary middleware in the stack, for reporting purposes we are probably going to print name if class, self.class.name otherwise (modulus I've not cheched how it looks).

Also, the middleware rake task should be consistent with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants