Switch token_tag if block #6171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if token == false || !protect_against_forgery? | ||
| '' | ||
| else | ||
| if token != false && protect_against_forgery? |
There was a problem hiding this comment.
Isn't this identical to if token &&...?
There was a problem hiding this comment.
I like the idea of easy to read code. How about this?
if token.present? && protect_against_forgery?
There was a problem hiding this comment.
if token && protect_against_forgery? is fine.
There was a problem hiding this comment.
This can receive nil when you don't give an explicit authentication_token, it's actually required to test != false for it to generate one automatically.
There was a problem hiding this comment.
Yes, we have to check if token is false which is different than nil.
|
I think we've explored all the edge cases to make a decision about this PR. |
rafaelfranca
added a commit
that referenced
this pull request
May 12, 2012
Switch token_tag if block
|
Merged. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale: easier to understand what's going on, easier to read.