Skip to content

Conversation

waseem
Copy link
Contributor

@waseem waseem commented May 25, 2012

This fixex build 4008.1[1] because of the changes made in

4001835

[1] http://travis-ci.org/#!/rails/rails/jobs/1429671

This fixex build 4008.1[1] because of the changes made in

4001835

[1] http://travis-ci.org/#!/rails/rails/jobs/1429671
@arunagw
Copy link
Member

arunagw commented May 25, 2012

Have you seen this #6473 ?

cc @tenderlove

@waseem
Copy link
Contributor Author

waseem commented May 25, 2012

@arunagw I think one should revert 4001835 then.

@waseem
Copy link
Contributor Author

waseem commented May 25, 2012

@arunagw I guess it's already been fixed in #6471. However, railties/lib/rails/paths.rb still needs to be fixed.

@arunagw
Copy link
Member

arunagw commented May 25, 2012

Yeah.

waseem added a commit to waseem/rails that referenced this pull request May 25, 2012
This fixes changes made in railties/lib/rails/paths.rb in
4001835. This also makes sure failures
in build 4008.1[1] pass.

Also closes rails#6482 and rails#6473

[1] http://travis-ci.org/#!/rails/rails/jobs/1429671/L203
josevalim added a commit that referenced this pull request May 25, 2012
@josevalim josevalim merged commit ec8c4b5 into rails:master May 25, 2012
@waseem
Copy link
Contributor Author

waseem commented May 25, 2012

@josevalim This has caused some more failures in latest build. http://travis-ci.org/#!/rails/rails/jobs/1430498/L549

@josevalim
Copy link
Contributor

I have fixed those ones. If there are more failures, please do send more
pull requests. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants