Skip to content

A small fix for an AR test case #8728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 3, 2013
Merged

A small fix for an AR test case #8728

merged 1 commit into from
Jan 3, 2013
+1 −1

Conversation

amatsuda
Copy link
Member

@amatsuda amatsuda commented Jan 3, 2013

Car.all here needs a to_a to execute SQL because Car.all alone just returns a Relation.

Actually, the test passes without base.silence_auto_explain do block if not to_a'ed.

rafaelfranca added a commit that referenced this pull request Jan 3, 2013
@rafaelfranca
Merge pull request #8728 from amatsuda/model_all_returns_a_relation
a896609 
A small fix for an AR test case
@rafaelfranca rafaelfranca merged commit a896609 into rails:master Jan 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amatsuda @rafaelfranca