Uniqueness validation uses a proc to specify the :conditions option.
#9633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@carlosantoniodasilva as discussed. |
|
👍 A deprecation would be nice, since it seems easy to support both formats. |
|
thanks @josevalim, I'll update to support both formats and issue a deprecation on the old style. |
|
I added a deprecation warning for the old syntax but it is still supported. |
|
@josevalim This feature was added to rails master only, so I think there's no need to deprecate. Sorry to make you undo the work @senny :) |
|
|
||
| validates_uniqueness_of :title, conditions: -> { where('approved = ?', true) } | ||
|
|
||
| *Yves Senn* |
There was a problem hiding this comment.
@senny I think the feature itself doesn't have a changelog entry, so perhaps you could make this the official one and put both yours and the other author names, wdyt?
This is a follow up to rails#5321 and follows the general direction in AR to make things lazy evaluated.
carlosantoniodasilva
added a commit
that referenced
this pull request
Mar 9, 2013
Uniqueness validation uses a proc to specify the `:conditions` option. This is a follow up to #5321 and follows the general direction in AR to make things lazy evaluated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #5321 and follows the general direction in AR to make things lazy evaluated.
Open points: