Fixes issue with process method not visible in integration tests #14071
Conversation
|
Any updates on this PR? It would be great to have this fix so we can test the OPTIONS verb in RSpec tests. In the meantime, if anyone knows of a workaround, it would be greatly appreciated. Thanks! |
|
Still waiting for feedback so far, no one from the Rails team has looked at it, it seems. |
|
Could you rebase it? |
Since process was private in ActionDispatch::Integration::RequestHelpers::Session, when you call process inside an integration test it would never call process on it as Ruby 2.0 and onwards only checks for public methods. Making it public allows it to be called again inside integration tests and fixes rspec/rspec-rails#925.
mauricio
force-pushed
the
fix-process-on-integration-tests
branch
from
89a59ee
to
316db75
Compare
|
@rafaelfranca rebased now. |
|
I'm running into this too. I'd like to test OPTIONS HTTP Method for CORS preflight requests. |
|
@jeremysears If you're using RSpec, you can test it with this workaround: This helper method: https://github.com/codeforamerica/ohana-api/blob/master/spec/support/request_helpers.rb#L9-L16 and specs that look like this: https://github.com/codeforamerica/ohana-api/blob/master/spec/api/cors_spec.rb |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Since
processwas private inActionDispatch::Integration::RequestHelpers::Session, when you callprocessinside an integration test it would never callprocessat the current session as Ruby 2.0 and onwards only checks for public methods andprocessbeing private is always a false result whenmethod_missinggets called insideActionDispatch::Integration::RequestHelpers::Runner.Making it public allows it to be called again inside integration tests and fixes rspec/rspec-rails#925.