Support the OPTIONS Http Verb in Integration tests #37369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ActionDispatch::Integration::Session#process already lists OPTIONS as a valid verb symbol to pass
BookOfGreg
changed the title
BookOfGreg
commented
Oct 4, 2019
|
I've needed this in the past, so this is a nice CORS correction 😂, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ActionDispatch::Integration::Session#process already lists OPTIONS as a valid verb symbol to pass
https://github.com/rails/rails/blob/master/actionpack/lib/action_dispatch/testing/integration.rb#L184
Therefore it should be as simple as allowing the method through.
Other Information
Rails doesn't appear to allow OPTIONS verb in it's router, so people depend on gems like Rack::Cors for it normally. However as part of adding Swagger support for both OPTIONS and TRACE verbs, I'm having to find work-around for this.
There is another conversation about testing using
:optionsin this conversation here where Rack::Cors uses :options on process directly, therefore this should work.#14071 (comment)