Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AzureStorage needs version >= 2 of azure-storage-blob #44965

Merged
merged 1 commit into from
May 9, 2022
Merged

AzureStorage needs version >= 2 of azure-storage-blob #44965

merged 1 commit into from
May 9, 2022

Conversation

equivalent
Copy link
Contributor

@equivalent equivalent commented Apr 26, 2022

Summary

active_storage_service needs version "~> 2.0" of azure-storage-blob because version 1.x of the gem doesn't support Ruby > 2.5 , more info: 0920b02

So I feel it's worth mentioning it in https://edgeguides.rubyonrails.org/active_storage_overview.html#microsoft-azure-storage-service

Credit for this goes to @skipkayhil for spotting this in issue I raised #44960
big thanks ! #legend

`active_storage_service`  needs version `"~> 2.0"`  of `azure-storage-blob`   because version 1.1.0 of the gem doesn't support Ruby > 2.5 0920b02

Credit for this  goes to   @skipkayhil  for spotting  this  in issue I raised #44960
@p8
Copy link
Member

p8 commented May 9, 2022

Thanks @equivalent !
I think this makes sense and we do the same thing for the "google-cloud-storage" gem:
85a63e6
It also uses a pessimistic lock which seems to make sense as we don't know if 3.0 will work (it might remove support for ruby 2.7).

@p8 p8 merged commit 068c783 into rails:main May 9, 2022
@equivalent equivalent deleted the patch-2 branch May 9, 2022 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants