Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVE 2022 3704 fix #46466

Closed
wants to merge 10,000 commits into from
Closed

CVE 2022 3704 fix #46466

wants to merge 10,000 commits into from

Conversation

ohsamarth
Copy link

Motivation / Background

This Pull Request has been created because #46244

Detail

This PR Contains a fix similar to the one proposed by @codergeek121 for CVE-2022-3704

Additional information

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.
  • CI is passing.

eileencodes and others added 30 commits March 9, 2022 09:22
…xists

Fix `remove_foreign_key` with `:if_exists` option when foreign key actually exists
If for some reason the files that defined those constants were loaded
before the `after_initialize` block, the values of the configuration
would not be applied.

With this new implementation we always use the configuration value, so
the order things are defined doesn't matter.
Remove unmaintained francesc/rails-translate-routes gem
Fix ChatRelayJob definition in Testing Guide [ci-skip]

(cherry picked from commit c3d4ab0)
…g-existing-classes-using-active-support-concern

Fix typo in engines guide for reopening existing classes using concern [ci-skip]

(cherry picked from commit e44d080)
…in-active-support-key-generator

Fixed rdoc typo highlighting for ActiveSupport::KeyGenerator class [ci-skip]

(cherry picked from commit a15543a)
Improve autoloading_and_reloading_constants.md [ci-skip]

(cherry picked from commit 0a2ba78)
…ezone-rdoc-activesupport

More rdoc improvements to activesupport [ci-skip]

(cherry picked from commit 5de5583)
…ct-prompt

Fix a bug with time_select and prompts
Allow relative redirects when `raise_on_open_redirects` is enabled
…-for-namespaced-controllers

Use `controller_class_path` in `Rails::Generators::NamedBase#route_url`
…ompat

Fix migrations compatibility for polymorphic references default index name
changed example cookie rotator to be in after_initialize block
…m-versions

Fix `#version` method docs and some typos [ci-skip]
…adcast

Fix TaggedLogging functionality when broadcasting to another logger:
…ings-when-provided

Only configure smtp_settings if provided on configuration
Get rid of `MySQL::SchemaStatements#create_table_sql`
[DOC] Introduce concerns example in Getting Started [ci-skip]

(cherry picked from commit da91d1c)
Rails 6.0 and Rails 6.1 didn't support the undocumented `before_remove_const` in
`zeitwerk` mode. I noticed this cleanup in AR was not being executed, and
restored the original code for Rails 7.

However, invoking `respond_to?` in an `on_unload` callback may have unexpected
side-effects, as seen in rails#44125. So, this patch reimplements the cleanup in a
more modern way.

Fixes rails#44125.
jonathanhefner and others added 29 commits August 9, 2022 12:23
(cherry picked from commit dce8b7f)
This makes "Connection Pool Options" a subsection of "Configuration",
instead of a subsection of "ActiveSupport::Cache::Store".  This also
makes "Custom Cache Stores" its own section after all of the built-in
stores, instead of a subsection of "ActiveSupport::Cache::Store".

(cherry picked from commit 0c97d1d)
Fix actiontext js not pointing to compiled file
Replace MutexHook by MonitorHook to allow reentrancy
Redis 3.0 compatiblity is preserved in Action Cable

Redis 4.0 compatiblity is preserved in Active Support
Backport Redis 5.0 compatibility (7-0-stable)
Fixes rails#45868 by Using #to_hash to serialize `AS::HWIA` for stored attributes
Stop gap solution for long output on test cases
…-guide-internal-link-errors

Make internal links to `errors` in the Active Record Validations guide
Add missing documentation for Rails.error
…ureing

Fix typo in "Configuring Rails Applications" guide

[ci-skip]
…y_downloads_files_larger_5mb

Fixes ActiveStorage proxy downloads of files over 5mb in S3-like storages
Fix eql? of AC::Parameters to match hash
…gger-broadcast"

This reverts commit 31925f5.

This was causing tags to leak to the broadcast logger when
`tagged` without a block is used.

Fix rails#45854.
Fix ServerTiming in Threads, use single subscriber
@ohsamarth ohsamarth closed this Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet