Allow relative redirects when raise_on_open_redirects is enabled
#44650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomhughes
force-pushed
the
relative-redirect
branch
from
2db0dbc to
24ebaa4
Compare
rafaelfranca
pushed a commit
that referenced
this pull request
Mar 14, 2022
Allow relative redirects when `raise_on_open_redirects` is enabled
brucebolt
added a commit
to alphagov/signon
that referenced
this pull request
Apr 13, 2022
Rails 7.0.2.3 has a bug where `redirect_back_or_to` (the replacement for `redirect_back`) does not work for relative URLs. This has been resolved in rails/rails#44650 but has not yet been included in a release of Rails. Therefore creating our own workaround, which can be removed once Rails is upgraded to a version containing this fix.
brucebolt
added a commit
to alphagov/signon
that referenced
this pull request
Apr 13, 2022
Rails 7.0.2.3 has a bug where `redirect_back_or_to` (the replacement for `redirect_back`) does not work for relative URLs. This has been resolved in rails/rails#44650 but has not yet been included in a release of Rails. Therefore creating our own workaround, which can be removed once Rails is upgraded to a version containing this fix.
brucebolt
added a commit
to alphagov/signon
that referenced
this pull request
Apr 13, 2022
Rails 7.0.2.3 has a bug where `redirect_back_or_to` (the replacement for `redirect_back`) does not work for relative URLs. This has been resolved in rails/rails#44650 but has not yet been included in a release of Rails. Therefore creating our own workaround, which can be removed once Rails is upgraded to a version containing this fix.
brucebolt
added a commit
to alphagov/signon
that referenced
this pull request
Apr 13, 2022
Rails 7.0.2.3 has a bug where `redirect_back_or_to` (the replacement for `redirect_back`) does not work for relative URLs. This has been resolved in rails/rails#44650 but has not yet been included in a release of Rails. Therefore creating our own workaround, which can be removed once Rails is upgraded to a version containing this fix.
brucebolt
added a commit
to alphagov/signon
that referenced
this pull request
Apr 13, 2022
Rails 7.0.2.3 has a bug where `redirect_back_or_to` (the replacement for `redirect_back`) does not work for relative URLs. This has been resolved in rails/rails#44650 but has not yet been included in a release of Rails. Therefore creating our own workaround, which can be removed once Rails is upgraded to a version containing this fix.
brucebolt
added a commit
to alphagov/signon
that referenced
this pull request
Apr 14, 2022
Rails 7.0.2.3 has a bug where `redirect_back_or_to` (the replacement for `redirect_back`) does not work for relative URLs. This has been resolved in rails/rails#44650 but has not yet been included in a release of Rails. Therefore creating our own workaround, which can be removed once Rails is upgraded to a version containing this fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Redirecting to a URL generated with
only_path: trueshould be allowed when open redirect protection is enabled because a relative URL with no host refers to the same host.