Fix ActionView backtrace filtering on Ruby 3.4+ #51590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I vote to stay consistent with other areas of Rails. |
|
Sorry, I see you already considered that. |
justinko
reviewed
Apr 17, 2024
rafaelfranca
approved these changes
Apr 18, 2024
jhawthorn
force-pushed
the
backtrace_cleaner_3_4
branch
from
1290f1d
to
5d39f4b
Compare
jhawthorn
force-pushed
the
backtrace_cleaner_3_4
branch
from
5d39f4b
to
3cf6122
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Ruby 3.4+ backtraces are going to use a single quote rather than a backtick https://bugs.ruby-lang.org/issues/16495
This adjusts our backtrace cleaner regex to work with either format. I considered making it just work on whatever output we expect to see from the current Ruby version, but we are already using a regex here and this seemed much simpler.