Remove channels from default app/ structure #52344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that Hotwire is the default, the majority of apps won't need custom channels. And those that do can get the files back via the generator.
|
Unrelated test failures. |
Schwad
pushed a commit
to Shopify/rails
that referenced
this pull request
Jul 18, 2024
* Remove channels from default app/ structure Now that Hotwire is the default, the majority of apps won't need custom channels. And those that do can get the files back via the generator. * Remove trailing space * Remove additional needless elements * No longer to be generated * No longer generated
hachi8833
added a commit
to hachi8833/rails
that referenced
this pull request
Aug 1, 2024
DanielaVelasquez
pushed a commit
to DanielaVelasquez/rails
that referenced
this pull request
Oct 3, 2024
* Remove channels from default app/ structure Now that Hotwire is the default, the majority of apps won't need custom channels. And those that do can get the files back via the generator. * Remove trailing space * Remove additional needless elements * No longer to be generated * No longer generated
DanielaVelasquez
pushed a commit
to DanielaVelasquez/rails
that referenced
this pull request
Oct 3, 2024
|
(Missed this one..) What about authenticating connections? ApplicationCable::Connection is used to authorize WebSocket access for all connections, Hotwire or not. Without it, anyone would be able to establish a connection and waste the server resources, i.e., perform a resource exhaustion attack. |
|
ah, you beat me to it. exactly what I though when looking at this PR |
|
Do the testing docs need to be updated?
I don't see that directory even after generating a channel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Hotwire is the default, the majority of apps won't need custom channels. And those that do can get the files back via the generator.