Add scroll padding for anchor links on mobile #219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I cannot tell the difference, am I missing something here?
|
p8
force-pushed
the
fix/mobile-anchor-links
branch
from
5c20fbd to
8046c7e
Compare
|
When you open the following anchor link on mobile you currently don't see the
With this PR you see the |
As the menu bar is fixed and overlaps the content we need to add scroll padding for the links to be visible.
p8
force-pushed
the
fix/mobile-anchor-links
branch
from
8046c7e to
1f3c153
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the menu bar is fixed on mobile and overlaps the content we need to add scroll padding for the anchor links to be visible.
Source: https://stackoverflow.com/a/56467997