Existing migration not updated by bin/rails generate solid_queue:install

[floehopper]

The notes in UPGRADING.md suggest that when you run bin/rails generate solid_queue:install after upgrading to v0.7.1, there should be a minor change to a migration. However, it seems as if the rails railties:install:migrations FROM=solid_queue step does not update / overwrite an existing version of the migration. Is this a limitation of railties?

I fixed this by deleting the existing migration, re-running rails railties:install:migrations FROM=solid_queue, overwriting the original migration with the code in the new migration.

This isn't causing me a problem any more, but I thought I'd mention it in case anyone else ran into the same issue.

[rosa]

Hmmm 🤔 That seems strange, we never modify existing migrations, only add new ones. Which migration changed for you?

[floehopper]

Which migration changed for you?

The one in #293

[floehopper]

It's just a fix to the #down method, so definitely not a big deal - my main confusion was that the upgrade guide suggested there was a small migration, but there didn't seem to be one. I was upgrading from v0.6.0 -> v0.7.1.

[rosa]

Ahh, you're totally correct! I had forgotten about the change to that #down method, and the small migration I was referring to was #283, but this one went out in v0.6.0 🤦‍♀️ I don't know why, I thought I had added it in version 0.7.0. I think it might have been because I was working on multiple changes in parallel and in the end, one went with 0.7.0 and the other with 0.6.0, and lost track of when I had merged that one.

I'll fix the upgrade instructions to remove that.

Thanks a lot for letting me know and sorry for the confusion 😳

[floehopper]

No worries - thanks for clarifying and fixing