Improve backtrace truncation #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosa
force-pushed
the
truncate-error-backtrace
branch
from
070936c to
e556466
Compare
So that instead of truncating to a fixed amount of lines, we check how much space we have and add lines until we hit the limit.
rosa
force-pushed
the
truncate-error-backtrace
branch
from
e556466 to
a77d387
Compare
They have variable size TEXT columns and return `nil` for the limit value. Just use the default TEXT size for MySQL as default.
For PostgreSQL and SQLite, instead of having them conform to the same limit as MySQL, just let them store the whole backtrace. I tried using a LONGTEXT column for MySQL but the schema is incompatible with PostgreSQL and SQLite, and it was getting a bit too complicated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that instead of truncating to a fixed amount of lines, we check how much space we have and add lines until we hit the limit.
This is a follow-up to #260