Support recurring jobs that defer enqueuing to after commit always #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These need to be enqueued within the transaction that creates the recurring execution to avoid duplicate crons. However, if the job is set to `enqueue_after_transaction_commit = :always` or :default when we change the default, it won't work because we'll try to create the recurring execution without having actually enqueued the job. With this change, we bypass Active Job's enqueuing and enqueue directly with Solid Queue, running enqueue callbacks.
rosa
force-pushed
the
fix-cron-jobs-enqueue-after-transaction-commit
branch
from
58d0cef to
e6a314c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These need to be enqueued within the transaction that creates the recurring execution to avoid duplicate runs. However, if the job is set to
enqueue_after_transaction_commit = :alwaysor:defaultwhen we change the default, it won't work because we'll try to create the recurring execution without having actually enqueued the job. With this change, we bypass Active Job's enqueuing and enqueue directly with Solid Queue, runningenqueuecallbacks.