Refactor processes: supervisor, dispatcher, worker, and all related concerns #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's used from there and over a relation. It makes more sense there.
With all the common stuff from workers, dispatchers and supervisor, and with a better structure: boot -> loop -> shutdown, with callbacks that run around boot and shutdown, but not around `run`, which happens inside start, and it was very hard to follow.
But keep its own #start method, since we want to handle the termination signals there. Also, improve some naming while I'm there.
I'll change Supervisor's mode later, because it's not the same as running mode, and it's confusing.
And set the mode explicitly, not in #start
Also, remove the idle threads value from metadata, because it's useless.
…ocess" and "fork" Much clearer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to make a bit clearer how these interact with each other and make concerns a little bit more self-contained without mixing things that have nothing to do with each other. It also improves naming across the board. No functionality is changed.