Fix undefined method .path on nil #246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, I got a undefined method call on .nil at line 106 of spring/application.rb. After deeper investigation I've found out that my Gemfile didn't have sinatra, but other gem required it. That caused spring to fail loading of rails app and crash. This simple change checks that Rails.application is there before accessing it. With this change it raises proper message that required file is not there.
|
Same issue here, and your fix works for me. I'd probably switch |
|
@jshafton changed |
jonleighton
added a commit
that referenced
this pull request
Feb 8, 2014
Fix undefined method .path on nil
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I got a undefined method call on .nil at line 106 of spring/application.rb.
After deeper investigation I've found out that my Gemfile didn't have sinatra, but other gem required it.
That caused spring to fail loading of rails app and crash.
This simple change checks that Rails.application is there before accessing it.
With this change it raises proper message that required file is not there.