fix the listen watcher #313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with the same substring than the root path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the listen watcher listening directories with a path that starts with the same substring than the root path. Before this fix, if a given directory had a path that starts equal to the root path, it would discard it thinking it would be a root subdirectory.
For example, the root path is a Rails app at ~/source/app and I also wanted to listen changes in another directory (that is a dependency) located at ~/source/app_core.
However, the listen watcher wasn't listening the ~/source/app_core because this logic checks if a given directory matches the beginning of the root path and not listening that.
This PR fixes it by correctly checking if a given directory is a subdirectory of the root directory and avoiding mistakes as described before.