Ensure bin/rails test command defaults to test` env
#403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end | ||
|
|
||
| test 'RailsTest#command sets rails environment from --environment option' do | ||
| command = Spring::Commands::RailsConsole.new |
There was a problem hiding this comment.
Should this be RailsTest instead of RailsConsole?
`bin/rails test` was defauling to the `development` environment because `ENV['RAILS_ENV']` and `ENV['RACK_ENV']` are nil and `default_rails_env` defaults to the `development` environment when an environment is not provided. This resulted in Spring ignoring even explicitly setting the environment option when running tests. The environment would get overwritten with `development` even when `test` was set. Tests seemed to run fine, but if there was a required file or included module the test would not be able to find those files because the environment was set incorrectly. Borrowing code from `RailsConsole` I updated `RailsTest` to set the default env to `test` but take `--environment` and `-e` into account like the other commands. I added tests to ensure that when not set the environment will default to `test`.
eileencodes
force-pushed
the
fix-environment-settings-on-spring
branch
from
06b4b9a to
497c1ee
Compare
|
👍 looks good. |
|
wow that took a long time, but woo green! 🍏 📗 💚 ♻️ |
|
@eileencodes this is the first green build from Travis that I've seen today. 🎉 💚 |
|
|
eileencodes
added a commit
that referenced
this pull request
Apr 28, 2015
…spring Ensure `bin/rails test command defaults to `test` env
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bin/rails testwas defauling to thedevelopmentenvironment becauseENV['RAILS_ENV']andENV['RACK_ENV']are nil anddefault_rails_envdefaults to the
developmentenvironment when an environment is notprovided.
This resulted in Spring ignoring even explicitly setting the environment
option when running tests. The environment would get overwritten with
developmenteven whentestwas set. Tests seemed to run fine, but ifthere was a required file or included module the test would not be able
to find those files because the environment was set incorrectly.
Borrowing code from
RailsConsoleI updatedRailsTestto set thedefault env to
testbut take--environmentand-einto accountlike the other commands.
I added tests to ensure that when not set the environment will default
to
test.Note: I opened a PR instead of pushing because I haven't work with Spring before. This seems like the right change based on the other commands. 😸