Fix STDOUT/ERR kept open after preload failure #423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great, I was expecting worse hackery :D |
|
Yeah, a test would be good please. Also needs a changelog entry. Thanks. |
|
It is very difficult to implement test case because it should use separated process and should be end-to-end test. |
|
@ypresto most of our tests are end-to-end tests so there is already a good structure for it. There's already a very similar test to the one that is needed here. |
ypresto
force-pushed
the
close-fd-preload-failure
branch
from
e601a48 to
c140ce8
Compare
|
Thanks, added test..! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #422
Thanks!