make help more accessible #429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(@rails-bot has picked a reviewer for you, use r? to override) |
|
Yeah agree 👍 |
grosser
force-pushed
the
grosser/help
branch
from
4441f36 to
cebbc1c
Compare
|
tests added, looking good ? |
|
|
||
| test "shows help" do | ||
| assert_success "bin/spring help", stdout: 'Usage: spring COMMAND [ARGS]' | ||
| assert_success "bin/spring --help", stdout: 'Usage: spring COMMAND [ARGS]' |
There was a problem hiding this comment.
added!
On Wed, Sep 9, 2015 at 10:09 AM, Rafael Mendonça França <
notifications@github.com> wrote:
In lib/spring/test/acceptance_test.rb
#429 (comment):@@ -84,6 +84,13 @@ def without_gem(name)
test "help message when called without arguments" do assert_success "bin/spring", stdout: 'Usage: spring COMMAND [ARGS]'
assert app.spring_env.server_running?end
test "shows help" doassert_success "bin/spring help", stdout: 'Usage: spring COMMAND [ARGS]'assert_success "bin/spring --help", stdout: 'Usage: spring COMMAND [ARGS]'Missing a test of -h?
—
Reply to this email directly or view it on GitHub
https://github.com/rails/spring/pull/429/files#r39069611.
grosser
force-pushed
the
grosser/help
branch
from
cebbc1c to
d7f4779
Compare
|
|
|
can you release a 1.4.0 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jonleighton @rafaelfranca
I found myself using
spring -htwice already ... would be nice if it was consistent with other commands and did not try to start a server (and keep it running in the background) when I use-h/--helpbecause I might be a new user and not even know that springs wantsspring help