Fix uncaught Gem::LoadError in binstub loader #448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @jonleighton (@rails-bot has picked a reviewer for you, use r? to override) |
| rescue LoadError => e | ||
| raise unless e.message.end_with? spring_bin_path, 'spring/binstub' | ||
| raise unless e.message =~ /spring/ |
There was a problem hiding this comment.
Should suffice, I'll update.
|
r? @grosser |
The previous binstub code did not catch Gem::LoadErrors which can be generated by bundler or rubygems trying to load the spring gem. This fixes rails#447.
felixbuenemann
force-pushed
the
fix-new-binstub-gem-load-error
branch
from
831bdcf to
1fea946
Compare
|
Updated to use |
|
Btw. I've manually tested against heroku with the new binstub code. |
grosser
added a commit
that referenced
this pull request
Nov 18, 2015
…error Fix uncaught Gem::LoadError in binstub loader
|
1.4.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous binstub code added in #444 did not catch Gem::LoadErrors which can be generated by bundler or rubygems trying to load the spring gem.
This fixes #447.