Ruby Warnings #593
Merged
Ruby Warnings #593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremy
approved these changes
Jun 10, 2019
| @@ -147,7 +147,7 @@ def serve(client) | |||
| log "got client" | |||
| manager.puts | |||
|
|
|||
| stdout, stderr, stdin = streams = 3.times.map { client.recv_io } | |||
| _stdout, stderr, _stdin = streams = 3.times.map { client.recv_io } | |||
There was a problem hiding this comment.
Seems we aren't using these local variables at all. Can we just remove them?
There was a problem hiding this comment.
We are using the stderr in the rescue block
| @@ -147,7 +147,7 @@ def serve(client) | |||
| log "got client" | |||
| manager.puts | |||
|
|
|||
| stdout, stderr, stdin = streams = 3.times.map { client.recv_io } | |||
| _stdout, stderr, _stdin = streams = 3.times.map { client.recv_io } | |||
| [STDOUT, STDERR, STDIN].zip(streams).each { |a, b| a.reopen(b) } | |||
There was a problem hiding this comment.
Might be clearer to do this explicitly, even 😅
-stdout, stderr, stdin = streams = 3.times.map { client.recv_io }
-[STDOUT, STDERR, STDIN].zip(streams).each { |a, b| a.reopen(b) }
+STDOUT.reopen(client.recv_io)
+STDERR.reopen(client.recv_io)
+STDIN.reopen(client.recv_io)
rafaelfranca
approved these changes
Jun 12, 2019
| @@ -147,7 +147,7 @@ def serve(client) | |||
| log "got client" | |||
| manager.puts | |||
|
|
|||
| stdout, stderr, stdin = streams = 3.times.map { client.recv_io } | |||
| _stdout, stderr, _stdin = streams = 3.times.map { client.recv_io } | |||
There was a problem hiding this comment.
We are using the stderr in the rescue block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some Ruby warnings.