Skip to content

Remove Sping::SID #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 23, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lib/spring/env.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
require "tmpdir"

require "spring/version"
require "spring/sid"
require "spring/configuration"

module Spring
Expand Down
3 changes: 2 additions & 1 deletion lib/spring/server.rb
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,8 @@ def rails_env_for(args, default_rails_env)
# This will cause it to be automatically killed once the session
# ends (i.e. when the user closes their terminal).
def set_pgid
Process.setpgid(0, SID.pgid)
pgid = Process.getpgid(Process.getsid)
Process.setpgid(0, pgid)
end

# Ignore SIGINT and SIGQUIT otherwise the user typing ^C or ^\ on the command line
Expand Down
42 changes: 0 additions & 42 deletions lib/spring/sid.rb

This file was deleted.

1 change: 0 additions & 1 deletion test/support/acceptance_test.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
require "io/wait"
require "timeout"
require "spring/sid"
require "spring/client"
require "active_support/core_ext/string/strip"

Expand Down