Allow to override environment on spring client startup #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spring.env_override can be set to - false (default) for current behaviour - true to always override client provided environment variables in the application - an array listing the environment variables to override in the application The after_fork callback can take an ptional argument that contains the Spring provided environment to help the application detect when there is a mismatch between application environment and provided environment.
|
|
||
| connect_database | ||
| srand | ||
|
|
||
| invoke_after_fork_callbacks | ||
| invoke_after_fork_callbacks(OpenStruct.new( |
There was a problem hiding this comment.
Can we create a class for this object here? It would allow us to document it for example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spring.env_override can be set to
application
application
The after_fork callback can take an ptional argument that contains the
Spring provided environment to help the application detect when there is
a mismatch between application environment and provided environment.
Fixes #653 and I believe will help with #420 (although a server restart is not performed, only environment overrides)